feat: 【告警】告警通知里，针对集群信息补充环境类型字段 --story=121108605 #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reviewed, transaction id: 26747
|
请在 PR 中添加项目标签，例如： |
|
请在 PR 中添加类型标签，例如： |
tang202388
added
feat
|
自测截图： |
chenguo367
requested changes
Dec 29, 2024
|
|
||
| if environment_types and bk_set_ids: | ||
| environments = [ | ||
| environment_mapping[environment_types[bk_set_id]] |
There was a problem hiding this comment.
需要考虑cmdb迭代的问题。 新增了环境类型的时候， 此时我们写死123，则会有异常。这块如果没有对应翻译，就直接给到对应的类型id即可。
# Reviewed, transaction id: 28113
tang202388
force-pushed
the
feat/add_env_type/#1010158081121108605
branch
from
1eca6bc to
e847b2e
Compare
|
自测截图补充： |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.