Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: 通知中心接入 (closed #2059) #2064

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

wyyalt
Copy link
Collaborator

@wyyalt wyyalt commented Jan 16, 2024

PR

CheckList(PR Assigners)

确认已完成以下操作:

  • 已将分支与当前合入分支同步
  • 已在关联 Issue 中补充「功能自测」部分内容
  • 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested(需通过测试同学测试) -> done
  • 将 PR 添加上 pr/reviewable

CheckList(PR Reviewers)

确认已完成以下操作:

  • 检查关联 Issue 「功能自测」部分内容
  • 必要时打回 pr/reviewable,要求重新修改
  • 及时 Approve

@wyyalt wyyalt added the pr/reviewable 可被 review 的 PR label Jan 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4eb9bc1) 74.71% compared to head (beb4773) 74.69%.

Files Patch % Lines
apps/node_man/apps.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           v2.4.4-dev    #2064      +/-   ##
==============================================
- Coverage       74.71%   74.69%   -0.02%     
==============================================
  Files             404      404              
  Lines           28248    28259      +11     
==============================================
+ Hits            21105    21109       +4     
- Misses           7143     7150       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wyyalt wyyalt requested review from CohleRustW and ping15 January 17, 2024 09:23
@wyyalt wyyalt merged commit ecf1711 into TencentBlueKing:v2.4.4-dev Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/reviewable 可被 review 的 PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants