Skip to content

Merge pull request #75 from Terasology/chore/qaplug-findings

Terasology Jenkins.io / CheckStyle succeeded Dec 10, 2023 in 0s

4 new issues, 57 total

Total New Outstanding Fixed Trend
57 4 53 0 👎

Reference build: Terasology » Modules » C » CoreRendering » develop #1

Details

Severity distribution of new issues

Error Warning High Warning Normal Warning Low
0 0 3 1

Annotations

Check warning on line 26 in src/main/java/org/terasology/corerendering/rendering/dag/nodes/WorldReflectionNode.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / CheckStyle

UnusedImportsCheck

NORMAL:
Unused import - org.terasology.engine.rendering.opengl.fbms.DisplayResolutionDependentFbo.
Raw output
<p>Since Checkstyle 3.0</p><p> Checks for unused import statements. Checkstyle uses a simple but very reliable algorithm to report on unused import statements. An import statement is considered unused if: </p><ul><li> It is not referenced in the file. The algorithm does not support wild-card imports like <code>import java.io.*;</code>. Most IDE's provide very sophisticated checks for imports that handle wild-card imports. </li><li> It is a duplicate of another import. This is when a class is imported more than once. </li><li> The class imported is from the <code>java.lang</code> package. For example importing <code>java.lang.String</code>. </li><li> The class imported is from the same package. </li><li><b>Optionally:</b> it is referenced in Javadoc comments. This check is on by default, but it is considered bad practice to introduce a compile time dependency for documentation purposes only. As an example, the import <code>java.util.Date</code> would be considered referenced with the Javadoc comment <code>{@link Date}</code>. The alternative to avoid introducing a compile time dependency would be to write the Javadoc comment as <code>{@link java.util.Date}</code>. </li></ul><p> The main limitation of this check is handling the case where an imported type has the same name as a declaration, such as a member variable. </p><p> For example, in the following case the import <code>java.awt.Component</code> will not be flagged as unused: </p><pre><code> import java.awt.Component; class FooBar { private Object Component; // a bad practice in my opinion ... } </code></pre>

Check warning on line 10 in src/main/java/org/terasology/corerendering/rendering/dag/nodes/SimpleBlendMaterialsNode.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / CheckStyle

UnusedImportsCheck

NORMAL:
Unused import - org.terasology.engine.rendering.cameras.Camera.
Raw output
<p>Since Checkstyle 3.0</p><p> Checks for unused import statements. Checkstyle uses a simple but very reliable algorithm to report on unused import statements. An import statement is considered unused if: </p><ul><li> It is not referenced in the file. The algorithm does not support wild-card imports like <code>import java.io.*;</code>. Most IDE's provide very sophisticated checks for imports that handle wild-card imports. </li><li> It is a duplicate of another import. This is when a class is imported more than once. </li><li> The class imported is from the <code>java.lang</code> package. For example importing <code>java.lang.String</code>. </li><li> The class imported is from the same package. </li><li><b>Optionally:</b> it is referenced in Javadoc comments. This check is on by default, but it is considered bad practice to introduce a compile time dependency for documentation purposes only. As an example, the import <code>java.util.Date</code> would be considered referenced with the Javadoc comment <code>{@link Date}</code>. The alternative to avoid introducing a compile time dependency would be to write the Javadoc comment as <code>{@link java.util.Date}</code>. </li></ul><p> The main limitation of this check is handling the case where an imported type has the same name as a declaration, such as a member variable. </p><p> For example, in the following case the import <code>java.awt.Component</code> will not be flagged as unused: </p><pre><code> import java.awt.Component; class FooBar { private Object Component; // a bad practice in my opinion ... } </code></pre>

Check warning on line 17 in src/main/java/org/terasology/corerendering/rendering/dag/nodes/SimpleBlendMaterialsNode.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / CheckStyle

UnusedImportsCheck

NORMAL:
Unused import - org.terasology.engine.rendering.world.WorldRenderer.
Raw output
<p>Since Checkstyle 3.0</p><p> Checks for unused import statements. Checkstyle uses a simple but very reliable algorithm to report on unused import statements. An import statement is considered unused if: </p><ul><li> It is not referenced in the file. The algorithm does not support wild-card imports like <code>import java.io.*;</code>. Most IDE's provide very sophisticated checks for imports that handle wild-card imports. </li><li> It is a duplicate of another import. This is when a class is imported more than once. </li><li> The class imported is from the <code>java.lang</code> package. For example importing <code>java.lang.String</code>. </li><li> The class imported is from the same package. </li><li><b>Optionally:</b> it is referenced in Javadoc comments. This check is on by default, but it is considered bad practice to introduce a compile time dependency for documentation purposes only. As an example, the import <code>java.util.Date</code> would be considered referenced with the Javadoc comment <code>{@link Date}</code>. The alternative to avoid introducing a compile time dependency would be to write the Javadoc comment as <code>{@link java.util.Date}</code>. </li></ul><p> The main limitation of this check is handling the case where an imported type has the same name as a declaration, such as a member variable. </p><p> For example, in the following case the import <code>java.awt.Component</code> will not be flagged as unused: </p><pre><code> import java.awt.Component; class FooBar { private Object Component; // a bad practice in my opinion ... } </code></pre>

Check warning on line 56 in src/main/java/org/terasology/corerendering/rendering/dag/nodes/FinalPostProcessingNode.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / CheckStyle

ConstantNameCheck

LOW:
Name 'noiseTextureSize' must match pattern '^([A-Z][A-Z0-9]*(_[A-Z0-9]+)*|logger)$'.
Raw output
<p> Checks that constant names conform to a format specified by the format property. A <em>constant</em> is a <strong>static</strong> and <strong>final</strong> field or an interface/annotation field, except <strong>serialVersionUID</strong> and <strong>serialPersistentFields</strong>. </p>