Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: address IntelliJ QAPlug plugin findings #32

Merged
merged 3 commits into from
Nov 27, 2023
Merged

refactor: address IntelliJ QAPlug plugin findings #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2ab50d
qa: make final field static
jdrueckert Oct 22, 2023
85bc3a3
qa: remove overrides that only call their super
jdrueckert Oct 22, 2023
c9a86d6
qa: remove unused local variable
jdrueckert Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/org/terasology/flexiblepathfinding/debug/ui/PathRequestLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ public void initialise() {
pathMetricLogs.bindText(new DefaultBinding<>() {
@Override
public String get() {
String results = "";
List<String> metricsStrings = system.lastPathMetricsResponseEvent.pathMetrics.stream()
.map(PathMetric::toString)
.collect(Collectors.toList());
Expand Down
5 changes: 0 additions & 5 deletions src/main/java/org/terasology/flexiblepathfinding/debug/ui/UIHistogram.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,6 @@ public org.joml.Vector2i getPreferredContentSize(Canvas canvas, Vector2i sizeHin
return new Vector2i(defaultWidth, defaultHeight);
}

@Override
public void update(float delta) {
super.update(delta);
}

public void bindValue(Binding<Histogram> binding) {
value = binding;
}
Expand Down
7 changes: 1 addition & 6 deletions src/main/java/org/terasology/flexiblepathfinding/debug/ui/UITimeSeries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
import java.util.Queue;

public class UITimeSeries extends CoreWidget {
private static final double padding = 2.0;
public Colorc color = Color.white;
private final double padding = 2.0;

private Binding<TimeSeries> binding = new DefaultBinding(new TimeSeries());

Expand Down Expand Up @@ -76,11 +76,6 @@ public Vector2i getPreferredContentSize(Canvas canvas, Vector2i sizeHint) {
return new Vector2i(defaultWidth, defaultHeight);
}

@Override
public void update(float delta) {
super.update(delta);
}

public void bindValue(Binding<TimeSeries> timeSeriesBinding) {
binding = timeSeriesBinding;
}
Expand Down
Loading