Fix collapsible brick slab blocks #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and added TFC_BRICK_SLAB_BLOCK_TYPES, although naming may be bad, because not all bricks are included there Signed-off-by: Egogorka <[email protected]>
Signed-off-by: Egogorka <[email protected]>
Egogorka
changed the title
|
It might be worth noting that this modifies recipes such as I think the change is still appropriate, and the recipes changed make sense too to me (you wouldn't really be using stone brick slabs for these purposes), but it should be pointed out. |
Xikaro
added
the
1. Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the new behavior?
This PR fixes collapsible bricks. Bricks are supposed to be sturdier than raw/smooth rock blocks. But even if bricks are not collapsible, brick slab blocks are for some reason. And because they can be used for decoration, it can bring a lot of pain.
Outcome
Brick slab blocks don't collapse
Potential Compatibility Issues
Constant
global.TFC_ROCK_SLAB_BLOCK_TYPESand tagstfg:rock_slabs,tfg:rock_stairs,tfg:rock_wallsgot changed contents. But search showed no other usage for them besides in the changed file in the code section for collapsible stuff, so it must be okay.