New settings management with optional django-siteprefs #61
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
terra_geocrud/map/styles.py
Outdated
| response = {} | ||
| if layer.is_point: | ||
| response = style_settings.get('point') | ||
| response = eval(app_settings.DEFAULT_STYLE_POINT) if isinstance(app_settings.DEFAULT_STYLE_POINT, str) \ |
There was a problem hiding this comment.
Use of possibly insecure function - consider using safer ast.literal_eval.
terra_geocrud/map/styles.py
Outdated
| elif layer.is_linestring: | ||
| response = style_settings.get('line') | ||
| response = eval(app_settings.DEFAULT_STYLE_LINE) if isinstance(app_settings.DEFAULT_STYLE_LINE, str) \ |
There was a problem hiding this comment.
Use of possibly insecure function - consider using safer ast.literal_eval.
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 94.13% 94.14% +0.01%
==========================================
Files 15 15
Lines 903 923 +20
==========================================
+ Hits 850 869 +19
- Misses 53 54 +1
Continue to review full report at Codecov.
|
terra_geocrud/views.py
Outdated
| 'point': eval(app_settings.DEFAULT_STYLE_POINT) if isinstance(app_settings.DEFAULT_STYLE_POINT, | ||
| str) | ||
| else app_settings.DEFAULT_STYLE_POINT, | ||
| 'polygon': eval(app_settings.DEFAULT_STYLE_POLYGON) if isinstance(app_settings.DEFAULT_STYLE_POLYGON, |
There was a problem hiding this comment.
Use of possibly insecure function - consider using safer ast.literal_eval.
|
Code Climate has analyzed commit dbcf62f and detected 0 issues on this pull request. View more on Code Climate. |
No description provided.