Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style-loader/mini-css-extract-plugin #7210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjonsson
Copy link
Contributor

What this PR does

Update style-loader and mini-css-extract-plugin
to the latest versions that are compatible
with webpack 4. The mini-css-extract-plugin
release notes recommend upgrading to style-loader
2.0.0 to avoid issues with esModule, so that
is why both are updated in the same commit.

The release notes for mini-css-extract-plugin 1.x
mention webpack 5 compatibility fixes, so this
update should simplify upgrading to webpack 5
when that time comes.

Test me

I'm guessing this is tested by CI?

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

Update style-loader and mini-css-extract-plugin
to the latest versions that are compatible
with webpack 4. The mini-css-extract-plugin
release notes recommend upgrading to style-loader
2.0.0 to avoid issues with esModule, so that
is why both are updated in the same commit.

The release notes for mini-css-extract-plugin 1.x
mention webpack 5 compatibility fixes, so this
update should simplify upgrading to webpack 5
when that time comes.
@@ -28,7 +28,6 @@ module.exports = function () {
plugins: [
new MiniCssExtractPlugin({
filename: "TerriaJS.css",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1.3.0 release adds checking of unknown options. I cannot find anything about the disable option in the release notes of mini-css-extract-plugin for any version, so I assume it is some leftover from elsewhere that should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant