Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language updates - Korean and Japanese and Traditional Chinese edition #989

Merged
merged 20 commits into from
Sep 20, 2023

Conversation

Daaaav
Copy link
Contributor

@Daaaav Daaaav commented Aug 21, 2023

Changes:

  • Synced language files to add the string from Remove NO_EDITOR/NO_CUSTOM_LEVELS, disable editor on Steam Deck #993
  • Increased the limit for strings at the bottom of the levels menu from 38*3 to 38*5
  • New languages: Korean and Traditional Chinese!
  • Another new language: Japanese! (based on Nicalis' translation for 3DS and Switch, with the blanks filled in by our new official Japanese translator, KabanFriends)
  • With the Korean and Japanese language files, this also adds the Korean and Japanese fonts
  • Updated these languages to be 99.9% complete (all strings except the Steam Deck editor one) (and fixed remaining issues we were aware of):
    • German
    • Russian
    • Spanish
    • Welsh
    • Ukrainian
    • Portuguese BR
    • Portuguese PT
    • Italian
    • Turkish
  • Updated these languages to be 100% complete:
    • Esperanto
    • Dutch
  • Fixed not both cases for "Complete the game" being referenced in the code

Legal Stuff:

By submitting this pull request, I confirm that...

  • My changes may be used in a future commercial release of VVVVVV
  • I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
    section of the credits for all of said releases, but will NOT be compensated
    for these changes

@InfoTeddy InfoTeddy added the localization Implies 'required for 2.4' unless otherwise noted label Aug 22, 2023
@InfoTeddy InfoTeddy self-assigned this Aug 22, 2023
@Daaaav Daaaav marked this pull request as draft August 22, 2023 12:10
@Daaaav Daaaav force-pushed the lang-updates-2023-08-20 branch 2 times, most recently from e2a1975 to 5bd90c7 Compare August 22, 2023 20:47
@Daaaav Daaaav changed the title Language updates - Korean edition Language updates - Korean and Japanese edition Aug 24, 2023
@Daaaav Daaaav force-pushed the lang-updates-2023-08-20 branch 2 times, most recently from 66bd89d to dd10d6a Compare August 25, 2023 18:31
@Daaaav Daaaav changed the title Language updates - Korean and Japanese edition Language updates - Korean and Japanese and Traditional Chinese edition Aug 25, 2023
@Daaaav Daaaav force-pushed the lang-updates-2023-08-20 branch 2 times, most recently from 7dd6621 to e64ca76 Compare August 27, 2023 16:31
@Daaaav Daaaav marked this pull request as ready for review August 28, 2023 14:37
This adds the following new strings from TerryCavanagh#993:
- The level editor is not currently supported on Steam Deck, as it
  requires a keyboard and mouse to use.
- The level editor is not currently supported on this device, as it
  requires a keyboard and mouse to use.

Unfortunately this means most languages won't be quite 100% anymore
for a bit, and updates come in which don't have this string yet.
But at least we can track it really well. In the next couple of
commits, when a language is updated with all new strings except for
these, I'll call them 99.9% instead of 100% (I did not get an actual
percentage).
The Korean localization has been delivered (next commit), so this
commit adds the font for it! The chosen font is Galmuri 9 (specifically
GalmuriMono9, version v2.38.7). It's licensed OFL, and since I had to
convert it to VVVVVV's bespoke font format and shift characters around,
I think we are now bundling a Modified Version of the font, and it has
to use the same license. Including it as font_ko_license.txt and
clearly indicating that the copyright came from the Original Version
should be more than enough.

This version is a bit more polished than the placeholder one posted on
Discord, namely (non-CJK) characters were shifted to fit into their
10x10 bounds as much as possible, and notably the , and . characters
were shifted 2 pixels to the right.
@Daaaav Daaaav force-pushed the lang-updates-2023-08-20 branch 2 times, most recently from fb179dc to 41b235a Compare September 1, 2023 15:46
New language! This uses the 10x10 font added in the previous commit.

This has some minor changes from the delivered version:
- Synced language files, and thus added max_local attributes
- Removed leftover Catalan strings in strings_plural (and reduced to
  just one form)
- Aligned terminal_finallevel
Also, the song names are now subtitled.
The next commit will be the initial commit adding the Japanese
translation, so here's the font!

Specifically, it's k8x12L (2021-05-05), and it can be downloaded (in
non-VVVVVV format) from https://littlelimit.net/k8x12.htm
- shifted certain "small" variants of katakanas by 1px (ェ, ュ)
- made the ツ and ヅ 1px taller
Another new language! And this is a very interesting one, since it's
based on Nicalis' translation for 3DS and Switch (with their go-ahead).
Which means I had to convert between two completely different
language file formats, which was some work, but it's totally worth it!

Naturally, there are a lot of missing strings, so a translator will
still need to fill in all the blanks (and maintain the translation for
new strings of course)
And another new language!

This uses the same font as Simplified Chinese. As such, I changed the
displayed name of the font (in the level editor) from 简体中文 to 中文.
This includes the Steam Deck editor strings.
Also, bumped the limit for "Font: " from 14 to 15, the Portuguese
translation is 15 characters and it just fits...
We had two separate cases for translators for this string (a
"TO UNLOCK:" one and a secret lab trophy one) but I forgot to use
the latter in the code, so both places in the game were using the
former. This is now fixed.
Japanese is 100% complete now, woo!
@InfoTeddy InfoTeddy merged commit b5d13d3 into TerryCavanagh:master Sep 20, 2023
3 checks passed
Daaaav added a commit to Daaaav/VVVVVV that referenced this pull request Sep 21, 2023
…Cavanagh#989

These PRs were open in parallel so this simply syncs the language files
back up.
InfoTeddy pushed a commit that referenced this pull request Sep 21, 2023
These PRs were open in parallel so this simply syncs the language files
back up.
@Daaaav Daaaav deleted the lang-updates-2023-08-20 branch September 21, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Implies 'required for 2.4' unless otherwise noted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants