Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small simplification to the composition of ProgressBar #4083

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Small simplification to the composition of ProgressBar #4083

merged 4 commits into from
Jan 31, 2024

Conversation

davep
Copy link
Contributor

@davep davep commented Jan 31, 2024

While suggested in #4054 I'm PRing this as a "before the main work" body of changes. This simply:

  • Removes a container from ProgressBar
  • Swaps some CSS to nested CSS (because reasons)
  • Makes various reactive-oriented methods into internals
  • Removes a type warning from ProgressBar.compose.update_percentage

@davep davep added enhancement New feature or request Task labels Jan 31, 2024
@davep davep self-assigned this Jan 31, 2024
@willmcgugan willmcgugan merged commit cd5e309 into Textualize:main Jan 31, 2024
20 checks passed
@davep davep deleted the progress-diet branch January 31, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@rodrigogiraoserrao rodrigogiraoserrao Awaiting requested review from rodrigogiraoserrao

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees

@davep davep

Labels
enhancement New feature or request Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davep @willmcgugan