Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding unbind methods to App #5600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

etyloppihacilem
Copy link

@etyloppihacilem etyloppihacilem commented Mar 1, 2025

Adding a method to App that allows to unbind a key previously bound.

class MyApp(App):
    def on_mount(self):
        self.bind("a", action="action1", description="description1")

app = MyApp()

app.unbind("a")  # removes the 'a' binding

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

I don't know if an update to documentation is needed as I correctly (ig ?) wrote the docstrings of the methods written in app.py and binding.py...

This may be linked to #2242 but disabling with unbind may be more permanent.

Unbind removes a binding that was previously added.

Adding tests for app.unbind method

Adding tests for app.unbind method
@etyloppihacilem etyloppihacilem changed the title Adding unbind methods to App feat: adding unbind methods to App Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant