Remove non-const overloads of front()

Signed-off-by: Omar Mohamed <[email protected]>
Thalhammer · Sep 29, 2024 · 70f0250 · 70f0250
1 parent feaca3c
commit 70f0250
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/include/jwt-cpp/jwt.h b/include/jwt-cpp/jwt.h
@@ -2464,7 +2464,7 @@ namespace jwt {
 										  is_iterable<array_type>::value &&
 										  is_detected<value_type_t, array_type>::value &&
 										  std::is_same<typename array_type::value_type, value_type>::value &&
-										  !std::is_same<decltype(std::declval<array_type>().front()), void>::value;
+										  std::is_member_function_pointer<decltype(&array_type::front)>::value;
 		};
 
 		template<typename string_type, typename integer_type>

diff --git a/include/jwt-cpp/traits/danielaparker-jsoncons/traits.h b/include/jwt-cpp/traits/danielaparker-jsoncons/traits.h
@@ -63,8 +63,6 @@ namespace jwt {
 			};
 			class array_type : public json::array {
 			public:
-				value_type& front() { return this->operator[](0U); }
-
 				value_type const& front() const { return this->operator[](0U); }
 			};
 			using string_type = std::string; // current limitation of traits implementation

diff --git a/include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h b/include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h
@@ -34,8 +34,6 @@ namespace jwt {
 				array_type& operator=(const array_type& o) = default;
 				array_type& operator=(array_type&& o) noexcept = default;
 
-				value_type& front() { return this->operator[](0U); }
-
 				value_type const& front() const { return this->operator[](0U); }
 			};
 			using number_type = double;