Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for the release of 0.7.0 #299

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Conversation

prince-chrismc
Copy link
Collaborator

We've had a a fair bit of stability and with the new round of contributions I'd love to cut a release and keep the changes coming :)

I also prep a draft release https://github.com/Thalhammer/jwt-cpp/releases/tag/untagged-3e7c021ab6f444d1e336 (you might have seen me misclick-- sorry sorry)

@prince-chrismc prince-chrismc added this to the 0.7.0 milestone Aug 1, 2023
@Thalhammer
Copy link
Owner

Would it make sense to maybe wait for #298 before we do a release ?
It seems to be mostly ready and I am pretty sure the author would be happy to be able to pin to a release tag instead of being force to master for his change.

@prince-chrismc
Copy link
Collaborator Author

That's totally reasonable to me!

@prince-chrismc
Copy link
Collaborator Author

Having done the work for #307 I think I have changed my mind.

I would rather cut a new release since there's some missing tests and it uses new openssl apis.

WDYT?

@prince-chrismc
Copy link
Collaborator Author

@Thalhammer I would like to keep this rolling and make this release, if you have any objections let me know :)

@Thalhammer
Copy link
Owner

@Thalhammer I would like to keep this rolling and make this release, if you have any objections let me know :)

Nope, looks good to me :)

@prince-chrismc
Copy link
Collaborator Author

Would you mind updating the Nuget API key? I suspect it has expired

@Thalhammer
Copy link
Owner

Would you mind updating the Nuget API key? I suspect it has expired

Done. And yes it was indeed expired. As far as I can tell its not possible to generate one thats valid for more than one year.

@prince-chrismc prince-chrismc merged commit 08bcf77 into Thalhammer:master Dec 10, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants