Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undefined behavior usage #301

Closed
wants to merge 2 commits into from
Closed

Remove undefined behavior usage #301

wants to merge 2 commits into from

Conversation

lirik90
Copy link

@lirik90 lirik90 commented Aug 11, 2023

It's possible fix for issue #300

Thalhammer
Thalhammer approved these changes Aug 11, 2023
View reviewed changes
Copy link
Owner

@Thalhammer Thalhammer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Seemed like a good fix to me

@prince-chrismc
Copy link
Collaborator

It seems the related test are now failing

[ RUN      ] BaseTest.Base64DecodeURLCaseInsensitive
unknown file: Failure
C++ exception with description "std::bad_alloc" thrown in the test body.
[  FAILED  ]

@lirik90
Copy link
Author

lirik90 commented Aug 15, 2023

Thanks. I'll check it out and come back with a solution.

@lirik90 lirik90 marked this pull request as draft August 16, 2023 02:30
@sjanel sjanel mentioned this pull request Aug 16, 2023
Open
@prince-chrismc
Copy link
Collaborator

Going to mark this as a duplicate of #312 thanks a ton for helping fix the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thalhammer Thalhammer Thalhammer approved these changes

Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lirik90 @prince-chrismc @Thalhammer