Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused header #329

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Remove unused header #329

merged 1 commit into from
Feb 6, 2024

Conversation

ErwanLegrand
Copy link
Contributor

The title tells it all. The codecvt header is no longer used in jwt-cpp therefore there is no reason to keep including it.

Copy link
Owner

@Thalhammer Thalhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. codecvt is deprecated in C++17 anyway and we don't use it anymore.

@Thalhammer Thalhammer merged commit 3e029c7 into Thalhammer:master Feb 6, 2024
57 checks passed
@ErwanLegrand ErwanLegrand deleted the old_gcc branch February 6, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants