Default constructor for jwks object #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whoever created the CI job to not only indicate exactly where the lining error is, but also generate a patch file and sample commands to apply it deserves a gold star. |
⭐ appreciate it 🙏 |
|
It would be amazing to have a test to help ensure this behavior is maintained :) Similar to But just check the list empty (you might need to usenthe itors to count) |
…efault-construct-jwks
|
@prince-chrismc I shouldn't have made the PR w/o a test. It's in. |
prince-chrismc
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I appreciate the design to always uphold the invariants of every type.
For
jwt::jwks, which is an object holding a collection of jwks, constructing an empty collection of jwks is valid and maintains the invariants of the type.The motivation for this is encapsulating
jwt::jwksin a caching class, where JWKs are often cached with periodic refreshing. There aren't any keys until fetched from issuer. I found myself doingjwt::jwks{"{\"keys\":[]}"}since there wasn't a default constructor, which feels silly.