Core/Misc: Remove incorrect (and unused) equality operator overloads …

…from LinkedListHead::Iterator class
The-Cataclysm-Preservation-Project · Oct 18, 2023 · 031e41c · 031e41c
1 parent 2e2a928
commit 031e41c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 36 deletions.
diff --git a/src/server/game/Maps/Map.cpp b/src/server/game/Maps/Map.cpp
@@ -3207,7 +3207,7 @@ Transport* Map::GetTransport(ObjectGuid const& guid)
 
 void Map::UpdateIteratorBack(Player* player)
 {
-    if (m_mapRefIter == player->GetMapRef())
+    if (&*m_mapRefIter == &player->GetMapRef())
         m_mapRefIter = m_mapRefIter->nocheck_prev();
 }
 

diff --git a/src/server/shared/Dynamic/LinkedList.h b/src/server/shared/Dynamic/LinkedList.h
@@ -160,7 +160,7 @@ class LinkedListHead
                 {                                           // construct with null node pointer
                 }
 
-                Iterator(pointer _Pnode) : _Ptr(_Pnode)
+                explicit Iterator(pointer _Pnode) : _Ptr(_Pnode)
                 {                                           // construct with node pointer _Pnode
                 }
 
@@ -206,40 +206,8 @@ class LinkedListHead
                     return (_Tmp);
                 }
 
-                bool operator==(Iterator const &_Right) const
-                {                                           // test for iterator equality
-                    return (_Ptr == _Right._Ptr);
-                }
-
-                bool operator!=(Iterator const &_Right) const
-                {                                           // test for iterator inequality
-                    return (!(*this == _Right));
-                }
-
-                bool operator==(pointer const &_Right) const
-                {                                           // test for pointer equality
-                    return (_Ptr != _Right);
-                }
-
-                bool operator!=(pointer const &_Right) const
-                {                                           // test for pointer equality
-                    return (!(*this == _Right));
-                }
-
-                bool operator==(const_reference _Right) const
-                {                                           // test for reference equality
-                    return (_Ptr == &_Right);
-                }
-
-                bool operator!=(const_reference _Right) const
-                {                                           // test for reference equality
-                    return (_Ptr != &_Right);
-                }
-
-                pointer _Mynode()
-                {                                           // return node pointer
-                    return (_Ptr);
-                }
+                bool operator==(Iterator const& _Right) const = default;
+                                                            // test for iterator equality
 
             protected:
                 pointer _Ptr;                               // pointer to node