Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents each arrow from independently proccing when double / triple firing with a bow #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mute
Copy link

@mute mute commented Nov 26, 2024

Right now, when double / triple attacking with a bow, each arrow the bow fires rolls procs independently. This means that each time the ranged attack timer elapses with a bow, you can proc up to 18 times (6x from weapon, 12x from spell procs).

This is pretty different from double attacking / triple attacking with a two handed weapon, for example, where each combat round you get one opportunity to proc, regardless of the whether or not your double and triple attack chances succeed. The equivalent combat round for a two handed weapon can proc up to 6 times.

Some random guy on Discord said this behavior wasn't intentional / desired (I don't know if this is accurate):
image

This fixes that behavior by skipping proc attempts on the arrows fired by successful double and triple bow shots.

4.0f here is the default value for the optional speed param of DoArcheryAttackDmg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant