added valid config check #2753
Merged
added valid config check #2753
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linting feedback Signed-off-by: Jeff Ng <[email protected]>
jeffng-or
force-pushed
the
at-add-valid-config-check
branch
from
b993ac4 to
dd9fa09
Compare
maliberty
approved these changes
Jan 30, 2025
luarss
reviewed
Jan 31, 2025
There was a problem hiding this comment.
In terms of valid config check, would you prefer to fail fast? I.e. fail at the argparse stage or wait till ray servers are started
There was a problem hiding this comment.
The failure would need to be at the individual run level, not at argparse. In other words, someone could do:
global: 0, 5
detailed 0, 5
then, AT chooses the following for a specific run:
global: 2
detailed: 4
which is invalid and we shouldn't even bother running OR.
I've got a checker that I will commit at some point that handles what we can check at the config file level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a valid config check to verify things like the global place padding >= detail place padding.
The check is done in the setup() method since we still have the data in a convenient form (dict) vs. dealing with the post processed data string that's held in the self.parameters. The action to skip the config is in the step() method, where we skip calling OR and just return ERROR_METRIC as the metric score.