Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grt: fix handle of obstructions in single gcells #5703

Merged
merged 38 commits into from
Dec 31, 2024
Merged

grt: fix handle of obstructions in single gcells #5703

merged 38 commits into from
Dec 31, 2024

Conversation

eder-matheus
Copy link
Collaborator

Fixes #5696.

Secure-ci is running.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus
gpl: update ok files
b5f20b1 
Signed-off-by: Eder Monteiro <[email protected]>
@eder-matheus
test: update metrics limits
f906305 
Signed-off-by: Eder Monteiro <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus eder-matheus marked this pull request as draft September 9, 2024 15:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus eder-matheus marked this pull request as draft October 8, 2024 03:57
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus
update metrics
9f35626 
Signed-off-by: Eder Monteiro <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus
gpl: update ok files
4fef1ab 
Signed-off-by: Eder Monteiro <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

maliberty
maliberty reviewed Dec 24, 2024
View reviewed changes
src/grt/src/GlobalRouter.cpp Outdated
@@ -689,7 +689,6 @@ void GlobalRouter::updateDirtyNets(std::vector<Net*>& dirty_nets)
dirty_nets.push_back(db_net_map_[db_net]);
routes_[db_net].clear();
db_net->clearGuides();
fastroute_->clearNetRoute(db_net);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because when we add the net to the dirty list, the route of it will be removed later when we add it to the FastRouteCore. Tho I believe I'll restore it, just to ensure the resources will be released.

@eder-matheus eder-matheus marked this pull request as ready for review December 24, 2024 17:16
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus
Copy link
Collaborator Author

@maliberty Thanks for approving it. Before the merge, I have to update some metrics in ORFS, so it will take a bit of time.

@eder-matheus eder-matheus merged commit 7fb347f into The-OpenROAD-Project:master Dec 31, 2024
11 checks passed
@eder-matheus eder-matheus deleted the grt_fix branch December 31, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osamahammad21 osamahammad21 osamahammad21 left review comments

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GRT: Bad GRT guides results in DRT break
3 participants
@eder-matheus @maliberty @osamahammad21