Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsz: allow negative hold and setup margins #6005

Merged
merged 2 commits into from
Oct 23, 2024
Merged

rsz: allow negative hold and setup margins #6005

merged 2 commits into from
Oct 23, 2024

Conversation

eder-matheus
Copy link
Collaborator

Fixes #6001

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

Please add a simple unit test to replace The-OpenROAD-Project/OpenROAD-flow-scripts#2500 (@oharboe )

@eder-matheus
Copy link
Collaborator Author

Please add a simple unit test to replace The-OpenROAD-Project/OpenROAD-flow-scripts#2500 (@oharboe )

Done

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty merged commit 18b51d9 into The-OpenROAD-Project:master Oct 23, 2024
10 checks passed
@eder-matheus eder-matheus deleted the rsz_negative_margins branch October 23, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ERROR STA-0572] -setup_margin '-500' is not a positive float.
2 participants
@eder-matheus @maliberty