drt: Contiguous GC data #6016
drt: Contiguous GC data #6016
Conversation
Signed-off-by: Krzysztof Bieganski <[email protected]>
Signed-off-by: Krzysztof Bieganski <[email protected]>
Signed-off-by: Krzysztof Bieganski <[email protected]>
Signed-off-by: Krzysztof Bieganski <[email protected]>
Signed-off-by: Krzysztof Bieganski <[email protected]>
Resizing these arrays could lead to dangling pointers and hard to find bugs. Signed-off-by: Krzysztof Bieganski <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| public: | ||
| dynarray() = default; | ||
| dynarray(std::vector<T>&& data) : data(std::move(data)) {} | ||
| dynarray(size_t size) : data(size) {} |
There was a problem hiding this comment.
warning: unknown type name 'size_t'; did you mean 'std::size_t'? [clang-diagnostic-error]
| dynarray(size_t size) : data(size) {} | |
| dynarray(std::size_t size) : data(size) {} |
Additional context
/usr/include/x86_64-linux-gnu/c++/11/bits/c++config.h:279: 'std::size_t' declared here
typedef __SIZE_TYPE__ size_t;
^| dynarray() = default; | ||
| dynarray(std::vector<T>&& data) : data(std::move(data)) {} | ||
| dynarray(size_t size) : data(size) {} | ||
| T& operator[](size_t idx) { return data[idx]; } |
There was a problem hiding this comment.
warning: unknown type name 'size_t'; did you mean 'std::size_t'? [clang-diagnostic-error]
| T& operator[](size_t idx) { return data[idx]; } | |
| T& operator[](std::size_t idx) { return data[idx]; } |
Additional context
/usr/include/x86_64-linux-gnu/c++/11/bits/c++config.h:279: 'std::size_t' declared here
typedef __SIZE_TYPE__ size_t;
^| dynarray(std::vector<T>&& data) : data(std::move(data)) {} | ||
| dynarray(size_t size) : data(size) {} | ||
| T& operator[](size_t idx) { return data[idx]; } | ||
| const T& operator[](size_t idx) const { return data[idx]; } |
There was a problem hiding this comment.
warning: unknown type name 'size_t'; did you mean 'std::size_t'? [clang-diagnostic-error]
| const T& operator[](size_t idx) const { return data[idx]; } | |
| const T& operator[](std::size_t idx) const { return data[idx]; } |
Additional context
/usr/include/x86_64-linux-gnu/c++/11/bits/c++config.h:279: 'std::size_t' declared here
typedef __SIZE_TYPE__ size_t;
^| auto begin() const { return data.begin(); } | ||
| auto end() { return data.end(); } | ||
| auto end() const { return data.end(); } | ||
| size_t size() const { return data.size(); } |
There was a problem hiding this comment.
warning: unknown type name 'size_t'; did you mean 'std::size_t'? [clang-diagnostic-error]
| size_t size() const { return data.size(); } | |
| std::size_t size() const { return data.size(); } |
Additional context
/usr/include/x86_64-linux-gnu/c++/11/bits/c++config.h:279: 'std::size_t' declared here
typedef __SIZE_TYPE__ size_t;
^
Store some of the GC data in contiguous arrays. The last commit is to ensure no one pushes to these vectors, as other code references this data via pointers, so we cannot invalidate them.
asap7/aesdrt-contiguous-gcasap7/ibexdrt-contiguous-gc