dpl: convert to storing markers in odb #6024
Conversation
|
@gadfort dpl got missed in the conversion to odb markers. |
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Matt Liberty <[email protected]>
openroad-robot
force-pushed
the
dpl-odb-markers
branch
from
25bc249
to
e3801c0
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
| double yMin = (failure->y_ + core.yMin()).v / dbUnits; | ||
| double xMax = (failure->x_ + failure->width_ + core.xMin()).v / dbUnits; | ||
| double yMax = (failure->y_ + failure->height_ + core.yMin()).v / dbUnits; | ||
| odb::dbMarker* marker = odb::dbMarker::create(category); |
There was a problem hiding this comment.
you need to check if this is a nullptr
If the category has reached it's limit, then this will return a nullptr
src/dpl/src/CheckPlacement.cpp
Outdated
|
|
||
| auto* tool_category = odb::dbMarkerCategory::createOrGet(block_, "DPL"); | ||
| try { |
There was a problem hiding this comment.
this try should not be needed anymore
src/dpl/src/CheckPlacement.cpp
Outdated
|
|
||
| auto* tool_category = odb::dbMarkerCategory::createOrGet(block_, "DPL"); |
There was a problem hiding this comment.
You might want to use createOrReplace if I run the check placement command twice and have placement failures at one time, but later I only have in row failures it would appear that both will be reported.
There was a problem hiding this comment.
I used
odb::dbMarkerCategory* tool_category
= odb::dbMarkerCategory::createOrGet(getBlock(), "PSM");
as a template. Is this incorrect too?
There was a problem hiding this comment.
also in connect.cpp and TritonRoute.cpp
There was a problem hiding this comment.
in PSM the net markers are in different categories so that get handled there. It's possible the behavior is not correct in the other places. (in PDN I believe I destroy the old markers first)
src/dpl/src/CheckPlacement.cpp
Outdated
| processViolationsPtree(entry, in_rows_failures); | ||
| drcArray.push_back(std::make_pair("", entry)); | ||
| auto category = odb::dbMarkerCategory::createOrReplace( | ||
| tool_category, "In_rows_failures"); |
There was a problem hiding this comment.
why not In rows failures? the placement failures didn't get an underscore.
src/dpl/src/CheckPlacement.cpp
Outdated
| auto category = odb::dbMarkerCategory::createOrReplace( | ||
| tool_category, "Placement_failures"); | ||
| category->setDescription("Cells that DPL failed to place."); | ||
| saveViolations(placement_failures, category); |
There was a problem hiding this comment.
how is this different from the previous placement failures?
src/dpl/src/CheckPlacement.cpp
Outdated
| } catch (std::exception& ex) { | ||
| logger_->error( | ||
| DPL, 45, "Failed to write JSON report. Exception: {}", ex.what()); | ||
| } |
Signed-off-by: Matt Liberty <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Agreed but I just moved this as is. |
No description provided.