Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odb: split LefDefParser namespace into LefParser and DefParser #6396

Merged
merged 13 commits into from
Jan 5, 2025
Merged

Odb: split LefDefParser namespace into LefParser and DefParser #6396

merged 13 commits into from
Jan 5, 2025

Conversation

LucasYuki
Copy link
Contributor

No description provided.

@LucasYuki LucasYuki requested a review from maliberty December 20, 2024 01:21
@LucasYuki
odb: formatting
5cb292c 
Signed-off-by: Lucas Yuki Imamura <[email protected]>
@LucasYuki
odb: formatting
25f3d63 
Signed-off-by: Lucas Yuki Imamura <[email protected]>
github-actions[bot]
github-actions bot reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 64. Check the log or trigger a new build to see more.

src/odb/include/odb/lefin.h Outdated Show resolved Hide resolved
src/odb/src/def/cdef/xdefiDebug.cpp Outdated Show resolved Hide resolved
src/odb/src/def/def/def_keywords.cpp Show resolved Hide resolved
src/odb/src/def/def/defiAlias.hpp Outdated Show resolved Hide resolved
src/odb/src/def/def/defiAssertion.hpp Outdated Show resolved Hide resolved
src/odb/src/def/def/defiProp.hpp Outdated Show resolved Hide resolved
src/odb/src/def/def/defiPropType.hpp Outdated Show resolved Hide resolved
src/odb/src/def/def/defiRegion.hpp Outdated Show resolved Hide resolved
src/odb/src/def/def/defiRowTrack.hpp Outdated Show resolved Hide resolved
src/odb/src/def/def/defiScanchain.hpp Outdated Show resolved Hide resolved
@LucasYuki @github-actions
Update src/odb/src/def/cdef/xdefiDebug.cpp
27c3d4c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: LucasYuki <[email protected]>
github-actions[bot]
github-actions bot reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 40. Check the log or trigger a new build to see more.

src/odb/src/def/cdef/xdefiDebug.cpp Show resolved Hide resolved
src/odb/src/def/def/defiSite.hpp Outdated Show resolved Hide resolved
src/odb/src/def/def/defiSlot.hpp Outdated Show resolved Hide resolved
src/odb/src/def/def/defiTimingDisable.hpp Outdated Show resolved Hide resolved
src/odb/src/def/def/defiUser.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefiDebug.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefiDefs.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefiEncryptInt.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefiLayer.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefiMacro.hpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/odb/src/lef/lef/lefiMisc.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefiNonDefault.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefiProp.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefiPropType.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefiUnits.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefrReader.cpp Show resolved Hide resolved
src/odb/src/lef/lef/lefrReader.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefrSettings.cpp Show resolved Hide resolved
src/odb/src/lef/lef/lefwWriter.hpp Outdated Show resolved Hide resolved
src/odb/src/lef/lef/lefwWriterCalls.hpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/odb/src/defin/definReader.h Show resolved Hide resolved
src/odb/src/defin/definReader.h Show resolved Hide resolved
src/odb/src/defin/definReader.h Show resolved Hide resolved
@LucasYuki
formatting
9f47eb1 
Signed-off-by: Lucas Yuki Imamura <[email protected]>
github-actions[bot]
github-actions bot reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/odb/src/defin/definReader.h Show resolved Hide resolved
src/odb/src/defin/definReader.h Show resolved Hide resolved
src/odb/src/defin/definReader.h Show resolved Hide resolved
@maliberty
Copy link
Member

It seems a mechanical change so I didn't review it line by line. There is one CI failure to resolve.

@LucasYuki
odb: fixing LefParser namespace
259981f 
Signed-off-by: Lucas Yuki Imamura <[email protected]>
@LucasYuki
formatting
73b5bb2 
Signed-off-by: Lucas Yuki Imamura <[email protected]>
@LucasYuki
Merge branch 'odb-split-lef-def'
93b40bf
@LucasYuki
odb: fixing namespace
8981056 
Signed-off-by: Lucas Yuki Imamura <[email protected]>
@LucasYuki
merge
c673bdd 
Signed-off-by: Lucas Yuki Imamura <[email protected]>
@maliberty maliberty merged commit 74c7c59 into The-OpenROAD-Project:master Jan 5, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasYuki @maliberty