msg: Add support for extra dependencies to messages function, convert odb to it and add extra dep to cts #6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
reviewed
Dec 30, 2024
src/cmake/messages.cmake
Outdated
| @@ -95,3 +95,65 @@ function(messages) | |||
| WORKING_DIRECTORY ${SOURCE_DIR} | |||
| ) | |||
| endfunction() | |||
|
|
|||
| function(messages_multi) | |||
There was a problem hiding this comment.
This appears to copy the messages function just to add a new DEPENDS argument. Could you just make take an option on the current one and handle if it is empty?
There was a problem hiding this comment.
Resent PR which extends messages function, convert odb and fix cts. Updated PR title. Thanks.
Signed-off-by: Christian Costa <[email protected]>
Signed-off-by: Christian Costa <[email protected]>
Signed-off-by: Christian Costa <[email protected]>
titan73
force-pushed
the
msg_multi_deps
branch
from
f047e93 to
7e1323f
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
titan73
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I created another PR #6468 as I accidentally trashed my branch and couldn't push a typo fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6406.
This is similar to what is done for odb but in a generic way that can be reused.
The new messages_multi cmake function can probably be merged in the messages one.