dpl: add API to get adjacent cells cluster #6522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
requested changes
Jan 14, 2025
bnmfw
reviewed
Jan 14, 2025
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
reviewed
Jan 14, 2025
maliberty
reviewed
Jan 14, 2025
maliberty
reviewed
Jan 14, 2025
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a public API for DPL that returns a cluster of instances, where every instances is adjacent to at least one instance inside the cluster.
This was requested by @bnmfw for his incremental pin access update.
This cluster should only contain instances that the pin access will do something, so tapcells and endcaps are ignored. Also, since macros are handled separately, they're also ignored.