dft: implementing interface to support different test modes #6533
Conversation
This is a refactoring change + public API change where we start supporting different tests modes. The test mode currently does nothing except for independendly architect and stitch each test mode. In the future, different tests modes may have different types of scan (ex: internal scan, scan compression, boundary scan, etc) and may support to include/exclude cells in certain modes. Signed-off-by: Felipe Garay <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Felipe Garay <[email protected]>
Signed-off-by: Felipe Garay <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
| @@ -124,3 +133,19 @@ proc report_dft_config { args } { | |||
| sta::parse_key_args "report_dft_config" args keys {} flags {} | |||
| dft::report_dft_config | |||
| } | |||
|
|
|||
|
|
|||
| sta::define_cmd_args "create_dft_test_mode" { [-test_mode test_mode] } | |||
There was a problem hiding this comment.
Is -test_mode really optional? If not provided the command is a silent no-op which seems unexpected.
There was a problem hiding this comment.
Ah, yeah, I will fix this, good point. I will revisit this PR on Friday
| @@ -9,6 +9,8 @@ link_design sub_modules | |||
|
|
|||
| create_clock -name main_clock -period 2.0000 -waveform {0.0000 1.0000} [get_ports {clock}] | |||
|
|
|||
| set_dft_config -max_chains 1 | |||
There was a problem hiding this comment.
This has no effect on the ok file and doesn't relate to test modes - what is the purpose?
| ScanArchitectConfig* getMutableScanArchitectConfig(); | ||
| const ScanArchitectConfig& getScanArchitectConfig() const; |
There was a problem hiding this comment.
Is there a reason one is by pointer and the other by reference?
| // Not copyable or movable. | ||
| TestModeConfig(const TestModeConfig&) = delete; | ||
| TestModeConfig& operator=(const TestModeConfig&) = delete; |
There was a problem hiding this comment.
You have no prevented moving, only copying.
| @@ -48,6 +48,8 @@ class ScanArchitectConfig | |||
| ClockMix // We architect the flops of different clock and edge together | |||
| }; | |||
|
|
|||
| ScanArchitectConfig() : clock_mixing_(ClockMixing::NoMix) {} | |||
There was a problem hiding this comment.
You can just do
ClockMixing clock_mixing_{NoMix};
and skip the ctor. Does this relate to test mode?
| if (name == kDefaultTestModeName) { | ||
| return createTestMode(name); | ||
| } | ||
| return nullptr; |
There was a problem hiding this comment.
getOrDefaultMutableTestModeConfig sounds like it should return default if not found.
|
It would be nice to add a test with multiple test modes even if it doesn't do much yet. |
This is a refactoring change + public API change where we start supporting different tests modes. The test mode currently does nothing except for independendly architect and stitch each test mode.
In the future, different tests modes may have different types of scan (ex: internal scan, scan compression, boundary scan, etc) and may support to include/exclude cells in certain modes.