Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grt: Jumper insertion improvement #6627

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

luis201420
Copy link
Contributor

New implementation of jumper insertion using DFS algorithm to find the GSegments that cause antenna violation for a pin.

The number of inserted jumpers increases because a jumper will be added to each GSegment connected to the pin with violation.

In the results obtained the number of diodes inserted in the post-GRT stage in most designs is reduced.

@luis201420 luis201420 changed the title Grt: jumper insertion improvement Grt: Jumper insertion improvement Jan 31, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/grt/src/RepairAntennas.cpp Show resolved Hide resolved
src/grt/src/RepairAntennas.h Outdated Show resolved Hide resolved
src/grt/src/GlobalRouter.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Feb 3, 2025

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus
Copy link
Contributor

@luis201420 CI have an error:
The following tests FAILED: grt.repair_antennas4.tcl (Failed)

src/grt/src/RepairAntennas.cpp Outdated Show resolved Hide resolved
src/grt/src/RepairAntennas.cpp Outdated Show resolved Hide resolved
src/grt/src/RepairAntennas.cpp Outdated Show resolved Hide resolved
src/grt/src/RepairAntennas.cpp Show resolved Hide resolved
src/grt/src/RepairAntennas.cpp Outdated Show resolved Hide resolved
src/grt/src/RepairAntennas.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Feb 3, 2025

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Feb 7, 2025

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

github-actions bot commented Feb 7, 2025

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@eder-matheus eder-matheus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luis201420 I have just these two new comments. After addressing them, you can start a secure-ci run.

src/grt/src/RepairAntennas.cpp Outdated Show resolved Hide resolved
src/grt/src/RepairAntennas.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Feb 7, 2025

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: luis201420 <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 8, 2025

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants