This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Add delete via reaction #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliver-makes-code
approved these changes
Sep 11, 2022
Ampflower
reviewed
Sep 11, 2022
There was a problem hiding this comment.
Seems fine to me. The only thing to perhaps change is moving the system fetch to inside when? Mostly for the ❓ and ❔ reactions, which doesn't need that lookup from the one reacting, only for the message reacted to.
It's a minor enough change that I'll fix it locally and merge.
Ampflower
added a commit
that referenced
this pull request
Sep 11, 2022
This commit also effectively merges #18
Ampflower
added a commit
that referenced
this pull request
Jul 12, 2023
This commit also effectively merges #18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds reacting with ❌ to delete.
Partial implementation of #15