Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOUNDATIONS: Contributor-AddAsync #226

Merged
merged 28 commits into from
Nov 11, 2024
Merged

FOUNDATIONS: Contributor-AddAsync #226

merged 28 commits into from
Nov 11, 2024

Conversation

SlimAhmad
Copy link
Collaborator

Closes #115

@SlimAhmad
ShouldAddContributorAsync -> FAIL
34a3a31
@SlimAhmad
ShouldAddContributorAsync -> PASS
21e8f64
@SlimAhmad
ShouldThrowValidationExceptionOnAddIfContributorIsNullAndLogItAsync -…
e4af4bc 
…> FAIL
@SlimAhmad
ShouldThrowValidationExceptionOnAddIfContributorIsNullAndLogItAsync -…
318e758 
…> PASS
@SlimAhmad
ShouldThrowValidationExceptionOnAddIfContributorIsInvalidAndLogItAsyn…
41e9090 
…c -> FAIL
@SlimAhmad
ShouldThrowValidationExceptionOnAddIfContributorIsInvalidAndLogItAsyn…
3d12b43 
…c -> PASS
@SlimAhmad
ShouldThrowValidationExceptionOnAddIfContributorHasInvalidLengthPrope…
7f997ad 
…rtiesAndLogItAsync -> FAIL
@SlimAhmad
ShouldThrowValidationExceptionOnAddIfContributorHasInvalidLengthPrope…
d724239 
…rtiesAndLogItAsync -> PASS
@SlimAhmad
CODERUB: Added extra fields in test
5968422
@SlimAhmad
ShouldThrowValidationExceptionOnAddIfAuditPropertiesIsNotTheSameAndLo…
866f92e 
…gItAsync -> FAIL
@SlimAhmad
ShouldThrowValidationExceptionOnAddIfAuditPropertiesIsNotTheSameAndLo…
d682d10 
…gItAsync -> PASS
@SlimAhmad
ShouldThrowValidationExceptionOnAddIfCreatedDateIsNotRecentAndLogItAs…
2a5d0bb 
…ync -> FAIL
@SlimAhmad
ShouldThrowValidationExceptionOnAddIfCreatedDateIsNotRecentAndLogItAs…
6961b89 
…ync -> PASS
@SlimAhmad
ShouldThrowCriticalDependencyExceptionOnAddIfSqlErrorOccurredAndLogIt…
945b506 
…Async -> FAIL
@SlimAhmad
ShouldThrowCriticalDependencyExceptionOnAddIfSqlErrorOccurredAndLogIt…
cd59805 
…Async -> PASS
@SlimAhmad
Revert "ShouldThrowCriticalDependencyExceptionOnAddIfSqlErrorOccurred…
ddad91f 
…AndLogItAsync -> PASS"

This reverts commit cd59805.
@SlimAhmad
Reapply "ShouldThrowCriticalDependencyExceptionOnAddIfSqlErrorOccurre…
d1d2390 
…dAndLogItAsync -> PASS"

This reverts commit ddad91f.
@SlimAhmad
ShouldThrowDependencyValidationExceptionOnAddIfContributorAlreadyExis…
f5cbbcf 
…tsAndLogItAsync -> PASS
@SlimAhmad
ShouldThrowDependencyExceptionOnAddIfDependencyErrorOccurredAndLogItA…
bf2c44e 
…sync -> FAIL
@SlimAhmad
ShouldThrowDependencyExceptionOnAddIfDependencyErrorOccurredAndLogItA…
0d5cdef 
…sync -> PASS
@SlimAhmad
ShouldThrowServiceExceptionOnAddIfServiceErrorOccurredAndLogItAsync -…
503f876 
…> FAIL
@SlimAhmad
ShouldThrowServiceExceptionOnAddIfServiceErrorOccurredAndLogItAsync -…
1067246 
…> PASS
@SlimAhmad
CODERUB: Added contributorService to program.cs and minor fix
e27bab7
@SlimAhmad
CODERUB: Added line break
9955396
@SlimAhmad SlimAhmad requested a review from glhays October 15, 2024 13:28
@glhays glhays requested review from cjdutoit and removed request for glhays October 15, 2024 16:34
@glhays glhays merged commit fe34310 into The-Standard-Organization:main Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdutoit cjdutoit cjdutoit left review comments

@glhays glhays glhays approved these changes

@hassanhabib hassanhabib Awaiting requested review from hassanhabib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FOUNDATIONS: Contributor AddAsync
3 participants
@SlimAhmad @cjdutoit @glhays