Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing a bug in the va_tax_credit_for_low_income_individuals line 43 #69

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

austinperryfrancis
Copy link
Contributor

@rickecon

There was an error in the code that biased the credit in my analysis, but I found it. It's just one line that only allows the credit if they are under the threshold. Here is my fix.

@rickecon
Copy link
Collaborator

@austinperryfrancis. Thanks for catching this. Looks great. I'll merge it as soon as all the tests pass.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8d3baf3) 98.57% compared to head (9785935) 98.57%.

Files Patch % Lines
...income/va_tax_credit_for_low_income_individuals.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files        1773     1773           
  Lines       26410    26410           
  Branches      142      142           
=======================================
  Hits        26033    26033           
  Misses        346      346           
  Partials       31       31           
Flag Coverage Δ
unittests 98.57% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickecon rickecon merged commit 78709c3 into TheCGO:main Nov 16, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants