Merge pull request #21 from TheDMSGroup/ENG-904-unable-to-pull-jan-21…

…-snapchat [ENG-904] unable to pull jan 21 snapchat
TheDMSGroup · May 27, 2019 · 33d5783 · 33d5783
2 parents 98ff9e7 + 4e2a682
commit 33d5783
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/Helper/SnapchatHelper.php b/Helper/SnapchatHelper.php
@@ -233,6 +233,7 @@ public function pullData()
             while ($date >= $this->getDateFrom()) {
                 /** @var AdAccount $account */
                 foreach ($accounts as $account) {
+                    $isComplete       = true;
                     $spend            = 0;
                     $clicksTotal      = 0;
                     $impressionsTotal = 0;
@@ -252,6 +253,9 @@ public function pullData()
                         $this->getDateTo()
                     ) as $campaign) {
                         $adStats = $this->getCampaignStats($campaign->id, $since, $until);
+                        if (empty($adStats)) {
+                            $isComplete = false;
+                        }
                         foreach ($adStats as $adStat) {
                             if (!$adStat) {
                                 continue;
@@ -331,7 +335,7 @@ public function pullData()
                         $clicksTotal,
                         $impressionsTotal,
                         // @todo - Add validation for completion for Snapchat data sets.
-                        true
+                        $isComplete
                     );
                 }
                 $date->sub($oneDay);
@@ -483,6 +487,8 @@ private function getRequest(
                     $this->refreshToken();
                     sleep(self::$betweenOpSleep);
                 } else {
+                    // We're not sure to handle this, nop.
+                    $done = true;
                     sleep(self::$betweenOpSleep);
                 }
             }