Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance directions #234

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Enhance directions #234

merged 1 commit into from
Mar 16, 2018

Conversation

khusbuchandra
Copy link
Contributor

Added Itinerary component to display the route instruction. Saves the route and provides feature to reverse route.

Issue : #150

Issue Description:

Enhance directions view and capabilities:

  • Add feature to save directions

  • Add reverse directions feature

  • Include alternate routes in preview

  • Customize routing text pane: partial map and text view, and hidden

Summary of solution:

  1. Used Leaflet easy button plugin
  2. Created an Itinerary component for displaying the instructions
  3. Saving the selected route with the backend api.

Can this issue be closed?

No

Should any new issues be added as a result of this solution?

  1. Styling of the Itinerary Component.
  2. On Mouseover of the instruction, it should display position kin map.
  3. Fetching saved directions

Have you named your branch in a descriptive way? Remember to name your branch in a unique and descriptive manner in order to properly reflect the issue or feature.

Yes, its 'enhance-directions-part1

Thanks for contributing!

Add Itinerary component to display the route instruction. Save the route and provide feature to reverse route.
@motosharpley motosharpley changed the base branch from development to directions-feature March 15, 2018 17:01
@motosharpley
Copy link
Collaborator

I created a new branch for directions-feature that we can use to build this out further. I also adjusted the base for this pr so that it will go to the directions-feature branch when we merge.

@@ -52,6 +52,7 @@
"express": "^4.16.2",
"helmet": "^3.9.0",
"jsonwebtoken": "^8.1.1",
"leaflet-easybutton": "^2.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something but I think this needs to be installed as a dependency for the client side not the server side

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. I completely missed it, Yes you are right it should be in Client. Thanks @jkwening . I think I was too lost in directions to notice it :-)

@jkwening jkwening mentioned this pull request Mar 16, 2018
@jkwening jkwening merged commit 5df7c0f into TheDevPath:directions-feature Mar 16, 2018
@jkwening jkwening removed the review label Mar 16, 2018
@jkwening
Copy link
Contributor

@khusbuchandra looks goods - I fixed the module issue that I noted and merged in accordingly. Another thing to add for next steps is using different color for alternative route; something lighter than the color being used for the main directions. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants