Skip to content

Commit

Permalink
Chore: Removed yarn test from contributing guide (#4879)
Browse files Browse the repository at this point in the history
<!-- Thank you for taking the time to contribute to The Odin Project. In
order to get this pull request (PR) merged in a reasonable amount of
time, you must complete this entire template. -->

## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
`yarn test` is no longer used in The Odin Project's main repo since
React was removed, and needs to be removed from CONTRIBUTING.md
instructions.

## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->
- `yarn test` removed from 'Testing Changes Locally' section in
CONTRIBUTING.md

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes #2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
#2013'.
-->
Closes #4856

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->


## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x',
e.g. [x]. After you create the PR, they will become checkboxes that you
can click on. -->
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
    - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
    - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [ ] I have verified all tests and linters pass after making these
changes.
- [x] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [ ] If applicable, this PR includes new or updated automated tests
  • Loading branch information
itsaflamingo authored Jan 29, 2025
1 parent 30c1170 commit 95e8e25
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Thank you for expressing interest in contributing to The Odin Project (TOP) web
This contributing guide assumes you have followed the instructions in our general contributing guide to fork and clone our web app repo.

## Table of Contents

- [How to Contribute](#how-to-contribute)
- [Running The Odin Project Locally](#running-the-odin-project-locally)
- [Adding Curriculum Content](#adding-curriculum-content)
Expand Down Expand Up @@ -35,5 +36,4 @@ Before submitting a pull request (PR) to our web app repo, you should run the fo
rubocop
yarn lint
rspec
yarn test
```

0 comments on commit 95e8e25

Please sign in to comment.