Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at ways to reduce code generation #38

Open
TheSpyder opened this issue Oct 31, 2021 · 1 comment
Open

Look at ways to reduce code generation #38

TheSpyder opened this issue Oct 31, 2021 · 1 comment

Comments

@TheSpyder
Copy link
Owner

TheSpyder commented Oct 31, 2021

Tasks already logged:

But I'd still like to note this as a general task to analyse the generated JS and see if ReScript techniques can be used to reduce the amount of it.

Mainly techniques like the ones described here
https://rescript-lang.org/docs/manual/latest/bind-to-js-function#trick-2-polymorphic-variant--unwrap

@tom-sherman
Copy link
Contributor

tom-sherman commented Dec 21, 2021

I tried to change Request.referrerPolicy to a polyvar in #66 but it ultimately didn't work as it uncovered a rescript formatting bug. See comment on PR for details.

I believe the same applies to destination.

Is there another way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants