New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert SelectionDirection and SelectionMode in HTMLInputElement #74

Open

illusionalsagacity opened this issue Dec 28, 2021 · 1 comment

Contributor

illusionalsagacity commented Dec 28, 2021

Our long term aim is to reduce the runtime code - when this library was written polymorphic variants were not strings. We can't convert existing modules until we do a wider breaking API change release in 2022, but for new modules we can make them as good as ReScript bindings allow.

So yes, please convert to polymorphic variants without runtime wrapping code.

Originally posted by @TheSpyder in #73 (comment)

implementation should use polymorphic variants as described above

Owner

TheSpyder commented Dec 28, 2021

There is a general tracking issue for this - #38

TheSpyder mentioned this issue

Look at ways to reduce code generation #38

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment