-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready] Re-Add Meta Station, Z-Level Sizing + Hole in Map Fix. #450
base: master
Are you sure you want to change the base?
Conversation
Fix Z-Level Size Issues(where the y was 2 times as large as its supposed to be) and put all of the turf and stuff back into where they belong.
closes #448 |
Edit: Forgot To Move the Areas along with the Turf/Obj, it is now Fixed. |
Mapmerge2 still isn't working it seems. Check that you installed it properly. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that areas are fixed it should be okay to merge, but what about "dmm before" file?
I don't think you really need it in the PR.
Adding the single Missing wire in Cargo/Arrivals Maintenance, |
/obj/item/a_gift/anything, | ||
/obj/item/a_gift/anything, | ||
/obj/item/a_gift/anything, | ||
/obj/item/a_gift/anything, | ||
/obj/item/a_gift/anything, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should really, really remove all of the anything in the /obj/item/a_gift/anything as those can spawn anything, from playing cards to an instakill rifle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just those I highlighted here, but the ones that are all around the station. Removing the anything part turns them in presents that only contain toys in them.
i like how this is still being TM'ed while it's closed |
About The Pull Request
It was noticed By LemonInTheDark that The Z-level for Meta Station showed up as x-255 and y-526 instead of x-255 and y-255, So i went and moved stuff back to where it should be so that there no longer was a Hole in arrivals and then had to do some adjustments before decreasing the Map Size, the Adjustments i made, was Giving Viro a West Wall again, putting up the Grille defenses Around Port Bow Solars, and Adding the Tiles to Cargo maints.
Why It's Good For The Game
These Changes Allows us to use Meta Station as a Map again and to be able to play on it,
once it is re added to the Map rotation of course.
Changelog
🆑
tweak: tweaked a few things
ix: fixed a few things
fix: fixed metastation issues
/:cl: