Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update radio_bridge_packet_decoder.js #865

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

megan-litterer
Copy link
Contributor

Summary

The current radio bridge decoder handles thermocouple events as a uint16 when it is a signed 16 bit number per https://multitech.com/wp-content/uploads/S000826_Radio-Bridge-LoRaWAN-Wireless-Sensors_User-Guide.pdf.

This caused issues where negative numbers looked like large positive numbers.

Changes

I added proper handling for a signed 16 bit variable.

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

Add proper handling for negative numbers in the thermocouple event
@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@Jaime-Trinidad Jaime-Trinidad merged commit 0265156 into TheThingsNetwork:master Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants