-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] use explicit not-exported flag for AudioBecomingNoisyReceiver #3327
[Android] use explicit not-exported flag for AudioBecomingNoisyReceiver #3327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙌
@AndyG were you able to compile library without bumping |
nope, def want to bump that, will make the necessary changes, test, and ping when ready. thanks for taking a look! |
@KrzysztofMoch I bumped that dependency and some related dependencies to keep them roughly in sync. I was able to use this source on a local build of my own app. Please let me know if you have any further concerns -- excited to help here but my react-native build tools experience is limited to be totally candid so a second opinion is extremely valuable. |
Thanks, I do some tests and we need to change some versions in order to keep kotlin version at
And we need to set minimal kotlin version to @freeboub I have checked and this ( |
okay thanks for the heads up. I have made those two changes in this PR, but not the kotlin version. Let me know how I can best support you to get this merged and released! |
…er (TheWidlarzGroup#3327) * using explicit not-exported flag for AudioBecomingNoisyReceiver * androidx.core:core version 1.9.0, androix.activity:activity version 1.6.0 --------- Co-authored-by: Andy G <Andy Garron>
…er (TheWidlarzGroup#3327) * using explicit not-exported flag for AudioBecomingNoisyReceiver --------- Co-authored-by: Andy G <Andy Garron>
Add
RECEIVER_NOT_EXPORTED
flag support toAudioBecomingNoisyReceiver
for Android 14 support. Seehttps://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.
Without this fix, apps using this dependency and targeting SDK 34 will crash when we attempt to register this receiver: