-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): fix external text tracks crashes with m3u8 files #3330
fix(ios): fix external text tracks crashes with m3u8 files #3330
Conversation
Thank you for the crash fix, but It would be better to make the functionality working :) |
@freeboub I have checked this and this is not working on 5.2 too (but is not crashing) |
Thank you for the test, so let's go with that |
if let description = _source?.description { | ||
mapping[.commonIdentifierDescription] = description | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There again spacing change.
But I accept these one 😆
@KrzysztofMoch I merged the PR for caching, this Pr now conflct with master... Sorry |
Summary
iOS does not support sideload subtitles for HLS playlist like m3u8. Added a safeguard so that such cases do not crash the application.
Test plan
textTracks
withm3u8
as source