Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(ios): restore caching feature #3341

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Fix(ios): restore caching feature #3341

merged 5 commits into from
Nov 13, 2023

Conversation

freeboub
Copy link
Collaborator

@freeboub freeboub commented Nov 8, 2023 •
edited
Loading

⚠️ This is a break change for integration

  • Update Video caching feature and fix build
  • Update documentation
  • Change integration step to enable the feature
  • update basic sample to allow easy testing on ios

Note to test this change:
You need to remove :
pod 'react-native-video/VideoCaching', :path => '../node_modules/react-native-video/react-native-video.podspec'
And replace it by:
$RNVideoUseVideoCaching=true

Fix issue: #3217

@freeboub freeboub changed the title Fix/restore ios caching Fix(ios): restore caching feature Nov 8, 2023
KrzysztofMoch
KrzysztofMoch approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@freeboub freeboub merged commit dfac7a6 into TheWidlarzGroup:master Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofMoch KrzysztofMoch KrzysztofMoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freeboub @KrzysztofMoch