Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(example): remove dependency loop #3353

Merged
merged 3 commits into from
Nov 17, 2023
Merged

fix(example): remove dependency loop #3353

merged 3 commits into from
Nov 17, 2023

Conversation

KrzysztofMoch
Copy link
Member

Summary

Remove dependency loop in basic example by static linking react-native-video

Test plan

  • basic example should run

@KrzysztofMoch KrzysztofMoch changed the title fix: example dependency loop fix(example): remove dependency loop Nov 16, 2023
@freeboub
Copy link
Collaborator

the Pr has conflict, can you double check please ?

@KrzysztofMoch KrzysztofMoch merged commit 211c3c7 into TheWidlarzGroup:master Nov 17, 2023
1 check passed
@KrzysztofMoch KrzysztofMoch deleted the fix/examples branch November 17, 2023 07:38
@KrzysztofMoch KrzysztofMoch mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrzysztofMoch @freeboub