fix: Fix types for ReactVideoSource to also allow require(..) sources
#3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rces We need to be careful here to not use `any`, so I used `NodeRequire` - which is afaik present in all React Native environments as a type.
freeboub
reviewed
Nov 16, 2023
CHANGELOG.md
Outdated
| @@ -27,6 +27,8 @@ | |||
|
|
|||
| ## Next | |||
| - Android, iOS: add onVolumeChange event #3322 | |||
| - Fix types for ReactVideoSource to also allow require(..) sources | |||
There was a problem hiding this comment.
you can remove this change for now, I will fix PR template, but thank for it 🙏
|
This Pr doesn't pass the linter step. notice that ideally we should move require option inside uri prop, but that is another subject ! |
freeboub
requested changes
Nov 16, 2023
Co-authored-by: Olivier Bouillet <[email protected]>
Co-authored-by: Olivier Bouillet <[email protected]>
|
Oh my bad I only checked typescript output - will fix linting now! |
|
@mrousavy I rework the fix here: https://github.com/react-native-video/react-native-video/pull/3361/files can you please check if it works for you ? |
|
My Pr has been merged, don't hesitate to comment on it if you see any issues with it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be careful here to not use
any, so I usedNodeRequire- which is afaik present in all React Native environments as a type.