Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): remove ads files only if not used #3372

Closed
wants to merge 3 commits into from

Conversation

avencat
Copy link
Contributor

@avencat avencat commented Nov 22, 2023

This fixes the usage of ads on Android (see #3370). Since beta0, the ads specific files were excluded only if we said we wanted them to be included.

You can test it by compiling the basic example project and adding this to build.gradle file in buildScript.ext:

RNVUseExoplayerIMA = true

I also had to update the kotlinVersion variable (I've set it to 1.9.20, also in the build.gradle file).

@freeboub
Copy link
Collaborator

@avencat Thank you for the PR, but I think this is not the good solution
I fixed the build issue here with this patch: fa23442 See the PR: #3376

@avencat
Copy link
Contributor Author

avencat commented Nov 22, 2023

Yes you're absolutely right, this fixes both the build issue and a crash when launching the video! 😉 I will close this PR then! 🙂

@avencat avencat closed this Nov 22, 2023
@avencat avencat deleted the fix/android-ads branch November 23, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants