Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): migrate from deprecated methods #3444

Merged
merged 2 commits into from
Jan 6, 2024
Merged

feat(ios): migrate from deprecated methods #3444

merged 2 commits into from
Jan 6, 2024

Conversation

KrzysztofMoch
Copy link
Member

@KrzysztofMoch KrzysztofMoch commented Dec 26, 2023

Summary

Part of #3425
Migrate AVAsset.tracks(withMediaType:) and AVAsset.mediaSelectionGroup(forMediaCharacteristic:) to newer equivalents

The diff on Github is pretty weird, so I recommend checking it in the editor

Why ?

To support visionOS and to improve performance by using async methods

Test plan

  • Tested in example app
  • CI passed

@KrzysztofMoch KrzysztofMoch mentioned this pull request Dec 26, 2023
16 tasks
@freeboub
Copy link
Collaborator

freeboub commented Jan 4, 2024

@KrzysztofMoch I approve the Pr, but I don't have time to test it for now.
Up to you to merge it !

@KrzysztofMoch KrzysztofMoch merged commit 5aaa53d into TheWidlarzGroup:master Jan 6, 2024
6 checks passed
@KrzysztofMoch KrzysztofMoch deleted the feat/migrate-from-deprecated-methods branch January 6, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants