Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable codegen #3647

Merged
merged 1 commit into from
Apr 3, 2024
Merged

chore: disable codegen #3647

merged 1 commit into from
Apr 3, 2024

Conversation

KrzysztofMoch
Copy link
Member

@KrzysztofMoch KrzysztofMoch commented Apr 3, 2024

Summary

We can not use Interop Layer with codegen - to be reverted once we integrate new architecture

Motivation

Add proper support for Interop Layer

Changes

  • removed codegen

Test plan

  • Tested locally
  • CI pass

We can not use Interop Layer with codegen - to be reverted once we integrate new architecture
@KrzysztofMoch KrzysztofMoch merged commit 1e5af7b into TheWidlarzGroup:master Apr 3, 2024
2 checks passed
@KrzysztofMoch KrzysztofMoch deleted the chore/disable-codegen branch April 3, 2024 18:51
@yungblud
Copy link
Contributor

@KrzysztofMoch I am wondering what is Interop Layer that you described.
Can you explain the reason you merged this PR more specifically?

@KrzysztofMoch
Copy link
Member Author

I am wondering what is Interop Layer that you described.

Interop Layer allow to use Old Arch components on New Arch - it's created by facebook to support community with New Arch migration - you can read more here

Can you explain the reason you merged this PR more specifically?

I am not sure now, but there was an issue with build when Interop Layer and Codegen was enabled at the same time - and folks from expo told me to disable it until we complete new arch migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants