fix(sample): update dependencies to fix local asset playback #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeboub
changed the title
…o into chore/sampleDependencies
freeboub
commented
Aug 29, 2024
…o into chore/sampleDependencies
seyedmostafahasani
approved these changes
Sep 1, 2024
KrzysztofMoch
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix playback of local assets broken since expo move in the sample
Motivation
Fix: #4120
Changes
Just upgrade sample dependencies (and upgrade expo in the same time)
The Root cause of the issue was due to react native windows version.
As described in the ticket @react-native/assets-registry was duplicated
One version from react native and one version for react native winwdows.
Fix react-native-windows version ensure the module is not downloaded twice
Test plan
Can be tested in the sample