Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expo-plugin) adding bg mode if none exist yet #4126

Merged
merged 1 commit into from
Aug 31, 2024
Merged

fix(expo-plugin) adding bg mode if none exist yet #4126

merged 1 commit into from
Aug 31, 2024

Conversation

blazlew
Copy link
Contributor

@blazlew blazlew commented Aug 30, 2024 •
edited
Loading

Summary

A simple fix. If the app happen to have empty "background modes" list, resulting in config.modResults.UIBackgroundModes to be undefined, the plugin tried to add audio mode to the fallback array that is not used anywhere, later on.

Motivation

Fix for #4125

Changes

  • push audio mode to UIBackgroundModes instead of unused fallback array

Test plan

  1. build the app with enableBackgroundAudio expo plugin flag set to true
  2. Notice the generated Info.plist (or in Xcode UI) doesn't contain UIBackgroundModes entry
  3. apply the fix and repeat

@freeboub freeboub requested a review from KrzysztofMoch August 30, 2024 15:10
@KrzysztofMoch KrzysztofMoch merged commit 451806c into TheWidlarzGroup:master Aug 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofMoch KrzysztofMoch KrzysztofMoch approved these changes

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blazlew @freeboub @KrzysztofMoch