Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): implements pip related method on web #4370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(web): implements pip related method on web #4370

wants to merge 1 commit into from
+54 −5

Conversation

YangJonghun
Copy link
Collaborator

Summary

implements pip related method on web

  • enterPictureInPicture
  • exitPictureInPicture
  • onPictureInPictureStatusChanged

Motivation

resolve #4358

Changes

  • enterPictureInPicture (If browser doesn't support, silently ignored)
  • exitPictureInPicture (If browser doesn't support, silently ignored)
  • onPictureInPictureStatusChanged

Test plan

@YangJonghun
Copy link
Collaborator Author

YangJonghun commented Jan 13, 2025 •
edited
Loading

FYI)
Library users have no control over attributes like disablePictureInPicture that are provided by browser.
I'm not sure if this is what you intended, but I hadn't thought about it.

zoriya
zoriya approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@zoriya zoriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

KrzysztofMoch
KrzysztofMoch approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofMoch KrzysztofMoch KrzysztofMoch approved these changes

@zoriya zoriya zoriya approved these changes

@freeboub freeboub Awaiting requested review from freeboub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Picture in Picture on Web
3 participants
@YangJonghun @zoriya @KrzysztofMoch