Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical - Add Unconscious Effects #716

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Medical - Add Unconscious Effects #716

wants to merge 3 commits into from

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Oct 25, 2024

When merged this pull request will:

  • Adds a screaming sound when you get knocked unconscious
  • Percentage of making a groaning sound while you're unconscious (if you have a heart rate above 40, this excludes CPR)
  • Uses sounds from ACE.
  • Has a disable setting, chance setting and a timer setting.
    • Enabled by default.
    • 50% by default.
    • 30s by default.
  • The groaning check is done locally on the unconscious person, uses the say3D event from mission (why its now a requirement).
  • PFH is removed when awake, so if you die it goes away.
  • Requested by El Presidente.

@Mike-MF Mike-MF requested a review from jonpas October 25, 2024 03:54
@Mike-MF Mike-MF added this to the 2.5.0 milestone Oct 25, 2024
@Mike-MF Mike-MF mentioned this pull request Oct 25, 2024
Merged
@jonpas jonpas modified the milestones: 2.5.0, 2.6.0 Oct 29, 2024
jonpas
jonpas reviewed Oct 29, 2024
View reviewed changes
addons/medical/initSettings.inc.sqf
[0.01, 1, 0.2, 2],
true // isGlobal
] call CBA_fnc_addSetting;

[
QGVAR(unconsciousFXEnabled),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting is unnecessary when chance can be set to 0%.

jonpas
jonpas reviewed Oct 29, 2024
View reviewed changes
addons/medical/functions/fnc_unconsciousFX.sqf
Comment on lines +4 to +6
* Handles noises while unconscious
*
* Called locally per player via target event
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Handles noises while unconscious
*
* Called locally per player via target event
* Handles noises while unconscious.
*
* Called locally per player via target event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mike-MF @jonpas