-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Add support for custom callback schemes #92
Conversation
Thank you very much for your PR! I will review it probably during the weekend :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a few things to think about or change. Thank you for your valuable PR!
* Fix crash/error when trying to open another window after closing a webview during the same application run
Sorry for the late response. I have merged your changes and made sure that the "legacy" way and your new approach are both still callable. |
This PR adds supports for custom callback schemes during authentication on Windows, by opening a new instance of the application that displays a webview (Microsoft WebView2).
Potential issues?
http://localhost
as the scheme) as there will no longer be a local server that listens for callsfixes #25
And should also (hopefully) fix #73